CopyHandler

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Small cleanups in code.

Rewritten part of the copy engine responsible directly for copying single file:

Removed configuration option "Create log file" - most of the logging was done without taking this option into consideration.

Extracted most of the basic file operations with feedback support from CustomCopyFile to separate methods.

Got rid of unneeded method.

Got rid of the last but one goto from code.

Uncommented line of code (commented out by mistake).

Reduced amount of information stored in the task description files.

Removed unused strings from the resources.

Got rid of a warning from a static analysis tool.

    • -1
    • +2
    /src/libictranslate/LanguageDialog.cpp
Added reporting of missing #define for resources from assertion to output text on cerr.

Removed /analyze option - caused build to fail with AfxWinInit having second argument NULL (which is really quite correct).

Removed storing/loading of total size and processed size of data to/from archive.

Task API improvements - added thread proc delegation function to avoid calling CTask methods with 'pTask->'.

Removed option 'auto-resume on error' - wasn't really used, did not work properly.

Removed functionality creating n copies of the original file - it made code more complicated, preventing core code from rewriting (hopefully nobody uses it).

Bugfix: 100% of a processor used by the clipboard monitoring thread.

Corrected code formatting.

  1. … 6 more files in changeset.
Corrected code formatting.

    • -1
    • +1
    /ext/libicpf/src/libicpf/circ_buffer.h
    • -4
    • +4
    /ext/libicpf/src/libicpf/config_property.cpp
    • -26
    • +26
    /ext/libicpf/src/libicpf/libicpf.h
Corrected code formatting.

    • -1
    • +1
    /src/libictranslate/LanguageDialog.cpp
Extracted operation time tracking to a local stats object.

Re-used worker thread controller in clipboard monitoring functionality.

Got rid of unused error code/message field in status dialog.

Bugfix: wrong calculations of the processed/total size.

Removed unused code, made some order in methods' visibility (public/protected).

Changed thread management code to use events and thread waitability instead of volatile bool variables.

    • -0
    • +194
    /src/ch/TWorkerThreadController.cpp
    • -0
    • +58
    /src/ch/TWorkerThreadController.h
Bugfix: wrong handling of multiple input paths (task copied the first file over and over).

Bugfix: dereferencing NULL pointers caused crashes and deadlocks in some cases.

Removed unnecessary code (LastProcessedIndex).

Second part of changes in progress management - local task stats are now separate entities and does not block other functionality.